GnosysLabs/GitHop
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop publishing repository-wide prompt ledgers and enforce per-user prompt isolation through authenticated Gitea IDs.

Browse Source 
Hop-State: A_06FN8NFDRFAFN5VCJTHJAAG
Hop-Proposal: R_06FN8NEGJ054CPMJF9ZAN70
Hop-Task: T_06FN8HT6XG332C3XY6PYCCG
Hop-Attempt: AT_06FN8HT6XGRXW0B4WPFFBJG
This commit is contained in:
cyph3rasi
2026-07-11 20:19:05 -07:00
committed by Hop
parent 56755a77fd
commit 12c806c77f
104 changed files with 255 additions and 1626 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/control-plane/internal/httpapi/server.go
+33 -3
View File
@@ -21,6 +21,8 @@ const maxWebhookBody = 2 << 20
type giteaClient interface {
Repository(context.Context, string, string) (gitea.Repository, error)
User(context.Context, string) (gitea.User, error)
AuthenticatedUser(context.Context, string) (gitea.User, bool, error)
ViewerCanReadRepository(context.Context, string, string, string) (bool, error)
}
@@ -51,7 +53,18 @@ func (s *server) listPrompts(w http.ResponseWriter, r *http.Request) {
writeError(w, http.StatusBadRequest, "owner and repo are required")
return
}
allowed, err := s.gitea.ViewerCanReadRepository(r.Context(), r.Header.Get("Cookie"), owner, name)
cookie := r.Header.Get("Cookie")
viewer, authenticated, err := s.gitea.AuthenticatedUser(r.Context(), cookie)
if err != nil {
s.logger.Error("load prompt viewer", "owner", owner, "name", name, "error", err)
writeError(w, http.StatusBadGateway, "could not verify signed-in user")
return
}
if !authenticated {
writeError(w, http.StatusUnauthorized, "sign in to view your prompts")
return
}
allowed, err := s.gitea.ViewerCanReadRepository(r.Context(), cookie, owner, name)
if err != nil {
s.logger.Error("check prompt viewer access", "owner", owner, "name", name, "error", err)
writeError(w, http.StatusBadGateway, "could not verify repository access")
@@ -61,7 +74,7 @@ func (s *server) listPrompts(w http.ResponseWriter, r *http.Request) {
writeError(w, http.StatusUnauthorized, "sign in to view this repository's prompts")
return
}
prompts, err := s.store.ListPrompts(r.Context(), owner, name, 100)
prompts, err := s.store.ListPrompts(r.Context(), owner, name, viewer.ID, 100)
if err != nil {
s.logger.Error("list prompts", "owner", owner, "name", name, "error", err)
writeError(w, http.StatusInternalServerError, "could not list prompts")
@@ -77,6 +90,7 @@ func (s *server) createPrompt(w http.ResponseWriter, r *http.Request) {
return
}
var input struct {
UserLogin string `json:"user_login"`
TaskID string `json:"task_id"`
AttemptID string `json:"attempt_id"`
StateID string `json:"state_id"`
@@ -92,6 +106,11 @@ func (s *server) createPrompt(w http.ResponseWriter, r *http.Request) {
writeError(w, http.StatusBadRequest, err.Error())
return
}
input.UserLogin = strings.TrimSpace(input.UserLogin)
if !validSlug(input.UserLogin) {
writeError(w, http.StatusBadRequest, "user_login is required")
return
}
input.Prompt = strings.TrimSpace(input.Prompt)
if input.Prompt == "" || len(input.Prompt) > 32<<10 {
writeError(w, http.StatusBadRequest, "prompt is required and must be at most 32 KiB")
@@ -110,9 +129,20 @@ func (s *server) createPrompt(w http.ResponseWriter, r *http.Request) {
writeError(w, http.StatusBadRequest, "metadata must be valid JSON and at most 16 KiB")
return
}
promptOwner, err := s.gitea.User(r.Context(), input.UserLogin)
if err != nil {
if errors.Is(err, gitea.ErrTokenNotConfigured) {
writeError(w, http.StatusServiceUnavailable, err.Error())
return
}
s.logger.Error("resolve prompt owner", "user_login", input.UserLogin, "error", err)
writeError(w, http.StatusBadGateway, "could not resolve prompt owner")
return
}
saved, err := s.store.CreatePrompt(r.Context(), store.CreatePromptInput{
Owner: owner, Repository: name, TaskID: input.TaskID, AttemptID: input.AttemptID, StateID: input.StateID,
Prompt: input.Prompt, AgentName: input.AgentName, AgentModel: input.AgentModel, Status: input.Status,
GiteaUserID: promptOwner.ID,
Prompt: input.Prompt, AgentName: input.AgentName, AgentModel: input.AgentModel, Status: input.Status,
ResponseSummary: input.ResponseSummary, Metadata: input.Metadata, CompletedAt: input.CompletedAt,
})
if err != nil {
services/control-plane/internal/httpapi/server_test.go
+32 -5
View File
@@ -20,6 +20,7 @@ import (
type fakeStore struct {
repositories []store.Repository
prompts []store.Prompt
listUserID int64
delivery store.WebhookDelivery
duplicate bool
}
@@ -33,11 +34,12 @@ func (f *fakeStore) UpsertRepository(_ context.Context, repository gitea.Reposit
f.repositories = append(f.repositories, saved)
return saved, nil
}
func (f *fakeStore) ListPrompts(context.Context, string, string, int) ([]store.Prompt, error) {
func (f *fakeStore) ListPrompts(_ context.Context, _, _ string, giteaUserID int64, _ int) ([]store.Prompt, error) {
f.listUserID = giteaUserID
return f.prompts, nil
}
func (f *fakeStore) CreatePrompt(_ context.Context, input store.CreatePromptInput) (store.Prompt, error) {
prompt := store.Prompt{ID: "PM_TEST", Prompt: input.Prompt, Status: input.Status, AgentName: input.AgentName, AgentModel: input.AgentModel, Metadata: input.Metadata}
prompt := store.Prompt{ID: "PM_TEST", GiteaUserID: input.GiteaUserID, Prompt: input.Prompt, Status: input.Status, AgentName: input.AgentName, AgentModel: input.AgentModel, Metadata: input.Metadata}
f.prompts = append(f.prompts, prompt)
return prompt, nil
}
@@ -48,13 +50,21 @@ func (f *fakeStore) RecordWebhook(_ context.Context, delivery store.WebhookDeliv
type fakeGitea struct {
repository gitea.Repository
user gitea.User
err error
viewerAllowed bool
authenticated bool
}
func (f fakeGitea) Repository(context.Context, string, string) (gitea.Repository, error) {
return f.repository, f.err
}
func (f fakeGitea) User(context.Context, string) (gitea.User, error) {
return f.user, f.err
}
func (f fakeGitea) AuthenticatedUser(context.Context, string) (gitea.User, bool, error) {
return f.user, f.authenticated, f.err
}
func (f fakeGitea) ViewerCanReadRepository(context.Context, string, string, string) (bool, error) {
return f.viewerAllowed, f.err
}
@@ -130,7 +140,7 @@ func TestWebhookRejectsInvalidSignature(t *testing.T) {
func TestListPromptsRequiresGiteaSession(t *testing.T) {
data := &fakeStore{prompts: []store.Prompt{{ID: "PM_TEST", Prompt: "Ship the prompt view", Status: "completed"}}}
handler := testServer(data, fakeGitea{viewerAllowed: true})
handler := testServer(data, fakeGitea{user: gitea.User{ID: 42, Login: "alice"}, viewerAllowed: true, authenticated: true})
req := httptest.NewRequest(http.MethodGet, "/api/v1/prompts?owner=hop&repo=demo", nil)
req.Header.Set("Cookie", "i_like_gitea=session")
response := httptest.NewRecorder()
@@ -141,6 +151,9 @@ func TestListPromptsRequiresGiteaSession(t *testing.T) {
if !bytes.Contains(response.Body.Bytes(), []byte("Ship the prompt view")) {
t.Fatalf("prompt missing from response: %s", response.Body.String())
}
if data.listUserID != 42 {
t.Fatalf("prompts listed for Gitea user %d, want 42", data.listUserID)
}
}
func TestListPromptsRejectsUnauthenticatedViewer(t *testing.T) {
@@ -155,8 +168,8 @@ func TestListPromptsRejectsUnauthenticatedViewer(t *testing.T) {
func TestCreatePrompt(t *testing.T) {
data := &fakeStore{}
handler := testServer(data, fakeGitea{})
req := httptest.NewRequest(http.MethodPost, "/api/v1/repositories/hop/demo/prompts", bytes.NewBufferString(`{"prompt":"Ship the prompt view","agent_name":"codex","status":"completed","metadata":{"duration_ms":1200}}`))
handler := testServer(data, fakeGitea{user: gitea.User{ID: 42, Login: "alice"}})
req := httptest.NewRequest(http.MethodPost, "/api/v1/repositories/hop/demo/prompts", bytes.NewBufferString(`{"user_login":"alice","prompt":"Ship the prompt view","agent_name":"codex","status":"completed","metadata":{"duration_ms":1200}}`))
req.Header.Set("Authorization", "Bearer admin-secret")
response := httptest.NewRecorder()
handler.ServeHTTP(response, req)
@@ -166,4 +179,18 @@ func TestCreatePrompt(t *testing.T) {
if len(data.prompts) != 1 || data.prompts[0].Prompt != "Ship the prompt view" {
t.Fatalf("prompt not created: %#v", data.prompts)
}
if data.prompts[0].GiteaUserID != 42 {
t.Fatalf("prompt owner = %d, want 42", data.prompts[0].GiteaUserID)
}
}
func TestCreatePromptRequiresOwner(t *testing.T) {
handler := testServer(&fakeStore{}, fakeGitea{})
req := httptest.NewRequest(http.MethodPost, "/api/v1/repositories/hop/demo/prompts", bytes.NewBufferString(`{"prompt":"private work","status":"completed"}`))
req.Header.Set("Authorization", "Bearer admin-secret")
response := httptest.NewRecorder()
handler.ServeHTTP(response, req)
if response.Code != http.StatusBadRequest {
t.Fatalf("status = %d, want %d; body=%s", response.Code, http.StatusBadRequest, response.Body.String())
}
}